browser-chat: make it work on mobile #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment for this PR has been generated and is available at: https://n0-computer.github.io/iroh-examples/pr/108 Last updated: 2025-02-25T10:32:45Z |
Frando
force-pushed
the
Frando/browser-chat-mobile
branch
from
275dc91 to
f6f3892
Compare
Member
Make it a hamburger menu, or just leave it! It's totally fine, this is an example :) |
matheus23
approved these changes
Feb 25, 2025
Member
matheus23
left a comment
matheus23
left a comment
There was a problem hiding this comment.
TYVM!
All I wanted was that the layout was reasonable & that the light/dark mode background worked reasonably, too. These things are accomplished! :)
Frando
force-pushed
the
Frando/browser-chat-mobile
branch
from
329546f to
61b76c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft at making it work on mobile. It is not yet perfect, but much better than before.
Please test on your phone and report any issues here!
Open questions
I'm not happy with the cog icon next to the send icon for going to peers and invite button etc.It was the easiest to do this way for now. Maybe move it to the header?