Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-metrics/pr/99/docs/iroh_metrics/ Last updated: 2026-03-16T15:27:24Z |
dignifiedquire
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates to reqwest version 0.13. This is only needed for the
iroh-metrics/servicefeature which I've so far only seen used in theiroh-relay/serverfeature.Unfortunately, I think that'll be pulled in with anyone who enables
iroh/test-utils.That said, I've changed the way reqwest is initialized to make sure it brings in ring instead of aws-lc-rs, just like before.
Breaking Changes
Should be none.
Notes & open questions
We could consider allowing users to pass in the
rustls::ClientConfigorreqwest::Clientthemselves (but at that point, we can just ask for a genericpostfunction instead).