Skip to content

feat: fix minimal crates selection #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dignifiedquire merged 19 commits into from
May 6, 2025
Merged

feat: fix minimal crates selection #3255

dignifiedquire merged 19 commits into from
May 6, 2025

Conversation

@dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Apr 3, 2025 •
edited
Loading

@dignifiedquire dignifiedquire requested a review from flub April 3, 2025 11:13
@dignifiedquire dignifiedquire changed the title deps: fix minimal crates selection chore: fix minimal crates selection Apr 3, 2025
@github-actions
Copy link

github-actions bot commented Apr 3, 2025 •
edited
Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3255/docs/iroh/

Last updated: 2025-05-06T12:24:56Z

@github-actions
Copy link

github-actions bot commented Apr 3, 2025 •
edited
Loading

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 3b1922d

@n0bot n0bot bot added this to iroh Apr 3, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Apr 3, 2025
flub
flub reviewed Apr 3, 2025
View reviewed changes
Cargo.toml Outdated
[patch.crates-io]
n0-future = { git = "https://github.com/n0-computer/n0-future", branch = "minimal-versions" }
portmapper = { git = "https://github.com/n0-computer/net-tools", branch = "minimal-versions" }
netwatch = { git = "https://github.com/n0-computer/net-tools", branch = "minimal-versions" }
Copy link
Contributor

@flub flub Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is blocked on these, but just adding a comment to not forget.

@matheus23
Copy link
Member

matheus23 commented Apr 3, 2025 •
edited
Loading

@dignifiedquire the Wasm failure is due to stun-rs depending (indirectly) on getrandom version 0.3 starting with version 0.1.10.
In the PR, you've configured 0.1.11 as the stun-rs version, this causes us to suddenly pull in getrandom 0.3 in iroh-relay, which we didn't do before.
Given that rand 0.9 dependencies are only going to get more common in the future (and in our transitive dependencies), I think there's no way around burdening our users with getrandom 0.3.
So we need to add a getrandom = { version = "0.3.0", features = ["wasm_js"] } wasm-gated dependency to iroh-relay.

rklaehn
rklaehn reviewed Apr 4, 2025
View reviewed changes
iroh/Cargo.toml
stun-rs = "0.1.11"
thiserror = "2"
tokio = { version = "1", features = [
tokio = { version = "1.44.1", features = [
Copy link
Contributor

@rklaehn rklaehn Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty recent. On the plus side it allows using https://docs.rs/tokio/latest/tokio/sync/oneshot/struct.Receiver.html#method.is_terminated I think...

rklaehn added a commit to n0-computer/iroh-experiments that referenced this pull request Apr 4, 2025
@rklaehn
Unbitrot tracker code
de6e118 
- update pkarr
- use workspace tokio
- explicitly specify tokio version until iroh minimal crates issues are solved n0-computer/iroh#3255
@dignifiedquire dignifiedquire changed the title chore: fix minimal crates selection feat: fix minimal crates selection May 1, 2025
@dignifiedquire dignifiedquire added this to the 0.35.0 milestone May 1, 2025
@dignifiedquire dignifiedquire added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit a62a2bd May 6, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh May 6, 2025
@ramfox ramfox deleted the minimal-versions branch May 6, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flub flub flub left review comments

@rklaehn rklaehn rklaehn left review comments

@ramfox ramfox ramfox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

iroh
Status: ✅ Done

Milestone

0.35.0

Development

Successfully merging this pull request may close these issues.

6 participants

@dignifiedquire @matheus23 @flub @rklaehn @ramfox