fix(iroh): Keep track of non-best-addr path validation and switch to them if best addr is soon outdated #3396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them if best addr is soon outdated
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3396/docs/iroh/ Last updated: 2025-07-18T16:40:55Z |
matheus23
force-pushed
the
matheus23/v0.35-asymmetric-send
branch
from
2ebabb7 to
38a7a6c
Compare
matheus23
commented
Jul 18, 2025
| @@ -18,7 +18,7 @@ env: | |||
| RUSTDOCFLAGS: -Dwarnings | |||
| MSRV: "1.81" | |||
| SCCACHE_CACHE_SIZE: "10G" | |||
| IROH_FORCE_STAGING_RELAYS: "1" | |||
| # IROH_FORCE_STAGING_RELAYS: "1" | |||
There was a problem hiding this comment.
This is the only way to turn off staging relays.
Unfortunately the staging relays are already on main, and main contains breaking changes to the relay wire protocol.
There was a problem hiding this comment.
... And apparently it's still not quite sufficient.
11 tasks
|
Closing this in favor of #3398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'd consider this mostly a workaround.
See also the humongous comment above
TRUST_UDP_ADDR_SOON_OUTDATED.Breaking Changes
Notes & open questions
Change checklist