fix(iroh): Track path validity for all paths and replace BestAddr with PathValidity
#3400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3400/docs/iroh/ Last updated: 2025-07-28T15:36:22Z |
matheus23
force-pushed
the
matheus23/path-validity
branch
from
c82809a to
48be424
Compare
dignifiedquire
approved these changes
Jul 28, 2025
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
…invalid (#3415) ## Description Fixes a bug introduced in #3400 We used to only reset `last_call_me_maybe` to `None` when the best address was cleared. The above PR accidentally changed that to always reset. ## Change checklist <!-- Remove any that are not relevant. --> - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3398 but now rebased on
main. See its description for more information.There's only one small change: We don't need to think about
NodeMap::reset, as that's removed inmain.Breaking Changes
None.
Notes & open questions
Change checklist