feat(iroh): add passive mode for mdns discovery (#3401) #3403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure in CI is not your fault. I've created #3404 to fix them. Once that's merged you can rebase on main (or merge main into your branch) and CI should be good. |
ramfox
approved these changes
Jul 28, 2025
Adds an `advertise` option to control whether a node broadcasts its presence via mDNS. When false, the node will only listen for other peers without advertising itself. This is useful for ephemeral nodes that need to discover services without spamming the local network with their own short-lived IDs.
Le-Maz
force-pushed
the
Le-Maz/passive-mdns-discovery
branch
from
e395ee1 to
3398d4c
Compare
|
Rebased the commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for passive mDNS discovery, enabling nodes to listen for peer advertisements without broadcasting their own presence on the local network.
Summary of changes:
advertise(bool)setter toMdnsDiscoveryBuilder(defaulttrue).MdnsDiscovery::newandspawn_discovererto respect theadvertiseflag.Breaking Changes
MdnsDiscovery::new(node_id: NodeId)→MdnsDiscovery::new(node_id: NodeId, advertise: bool)Code using
MdnsDiscovery::newmust now provide theadvertiseargument explicitly.Notes & Open Questions
Change Checklist