fix(proto): display for CONNECTION_CLOSE frame#554
Merged
Conversation
The auto-generated display was wrong and did not clearly show what frame this was when it was being built or received. This shows up better in the logs.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/554/docs/noq/ Last updated: 2026-03-31T15:14:42Z |
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5426.5 Mbps | 7612.6 Mbps | -28.7% | 99.8% / 161.0% |
| medium-concurrent | 5505.5 Mbps | 6883.8 Mbps | -20.0% | 98.9% / 162.0% |
| medium-single | 4271.2 Mbps | 4082.2 Mbps | +4.6% | 94.1% / 108.0% |
| small-concurrent | 3883.3 Mbps | 5012.5 Mbps | -22.5% | 96.7% / 110.0% |
| small-single | 3575.0 Mbps | 4410.5 Mbps | -18.9% | 90.7% / 98.1% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3072.4 Mbps | 4118.3 Mbps | -25.4% |
| lan | 782.4 Mbps | 809.5 Mbps | -3.4% |
| lossy | 69.8 Mbps | 55.9 Mbps | +24.9% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 19.4% slower on average
matheus23
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The auto-generated display was wrong and did not clearly show what
frame this was when it was being built or received. This shows up
better in the logs.
Breaking Changes
our display names are not part of the api??
(i say, knowing that won't be true, can't be true. sadness)
Notes & open questions
n/a