noq-proto: fix CID exhaustion check overflow on 32-bit targets#564
Merged
flub merged 1 commit inton0-computer:mainfrom Apr 3, 2026
Merged
noq-proto: fix CID exhaustion check overflow on 32-bit targets#564flub merged 1 commit inton0-computer:mainfrom
flub merged 1 commit inton0-computer:mainfrom
Conversation
flub
approved these changes
Apr 3, 2026
Collaborator
flub
left a comment
There was a problem hiding this comment.
Thanks!
We do need to merge Quinn's changes into noq again sometime soon. And really need to set up a more structured approach to that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an overflow in
Endpoint::cids_exhausted()on 32-bit targets when CID length is 4.The previous check used
usizeexponentiation:2usize.pow(cid_len * 8)overflows forcid_len == 4on 32-bit platforms (2^32does not fit inusize).This change is already merged into quinn: quinn-rs/quinn#2533
Changes
u64.Notes
cid_len == 0andcid_len > 4.