Conversation
if you don't do that, nothing super bad happens, but reopening the store takes longer.
Also measure import time.
ramfox
approved these changes
Jul 4, 2025
Member
ramfox
left a comment
ramfox
left a comment
There was a problem hiding this comment.
Looks good! Also tested it locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of changes, but most of them are related to progress bars.
Another important thing is to make sure shutdown is called in every case. If you stop the process before calling shutdown, the very last write might not be conserved, and you will end up re-requesting that chunk on next try.