Moved hot key handling and clipboard impl to crossterm.#95
Moved hot key handling and clipboard impl to crossterm.#95rklaehn merged 9 commits inton0-computer:mainfrom
Conversation
In raw mode, the cursor won't go back to line beginning when '\n' is printed. A '\r' would mannually reset the error message.
|
I need someone with Windows device to test whether Ctrl+C will quit the default compiled program, thanks! You need to:
|
> If the function succeeds, the return value is nonzero.
|
Having tested it on my friend's Windows 10 PC with Windows Terminal. The above process works as expected. |
robertkirkman
left a comment
There was a problem hiding this comment.
I have tested building and running this PR for Termux (Android) and I can confirm that it also prevents the problem of terminal output breaking after pushing Ctrl + C to stop sending on Termux.
|
So how do I reproduce this with the original sendme? Run it on windows and then hit control-c? Ah, never mind. It is in the issue. |
|
Windows may or may not be affected by the original issue, I just want to check if the PR works on Windows. Never mind, I have tested it on my friend's Windows 10 PC. |
Closes #94.
However, this brings more dependencies and is expected to longer compilation time.
The buggy
read_keyimpl inconsolewill keep the terminal in raw mode, where subsequent commands in shell won't see echo.What's more, Ctrl+C used by tokio is tricky on Windows, so I am not aware how to trigger that correctly in new clipboard handling block.