Merged
Conversation
Contributor
Author
|
I will rename file once 684 are merge |
Contributor
Author
|
need also HarbourMasters/Torch#166 |
MegaMech
requested changes
Jan 4, 2025
MegaMech
requested changes
Jan 4, 2025
asm/non_matchings/code_80005FD0/update_player_path_completion.s
Outdated
Show resolved
Hide resolved
asm/non_matchings/code_80005FD0/update_player_path_completion.s
Outdated
Show resolved
Hide resolved
Collaborator
|
The file name cpu_logic doesn't encompass everything that goes on in this function:
Could you try splitting the file? Or is that what this is? |
MegaMech
reviewed
Jan 15, 2025
MegaMech
requested changes
Jan 18, 2025
MegaMech
requested changes
Jan 18, 2025
MegaMech
requested changes
Jan 18, 2025
src/cpu_vehicles_camera_path.c
Outdated
| void set_current_path(s32 pathIndex) { | ||
| gCurrentTrackPath = gTrackPaths[pathIndex]; | ||
| gCurrentTrackInnerPath = gTrackInnerPath[pathIndex]; | ||
| gCurrentTrackOuterPath = gTrackOuterPath[pathIndex]; |
Collaborator
There was a problem hiding this comment.
Are you sure about this inner outter path? Are they actually separated paths?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.