Skip to content

fix(Slack Trigger Node): Fix user ignore filter for message_changed events#23894

Open
mag123c wants to merge 2 commits inton8n-io:masterfrom
mag123c:fix/slack-trigger-ignore-message-changed
Open

fix(Slack Trigger Node): Fix user ignore filter for message_changed events#23894
mag123c wants to merge 2 commits inton8n-io:masterfrom
mag123c:fix/slack-trigger-ignore-message-changed

Conversation

@mag123c
Copy link

@mag123c mag123c commented Jan 6, 2026

Summary

Fix Usernames or IDs to Ignore filter not working for message_changed events.

When Slack asynchronously enriches messages (e.g., adding locale metadata for non-English languages), it sends a message_changed event where the user ID is in event.message.user instead of event.user. The ignore filter was only checking event.user, causing the filter to fail and resulting in infinite loops.

Now checks both event.user and event.message.user (as fallback).

Related Linear tickets, Github issues, and Community forum posts

Issue: #23782

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Jan 6, 2026
@n8n-assistant
Copy link
Contributor

n8n-assistant bot commented Jan 6, 2026

Hey @mag123c,

Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request.

Before we can proceed, please ensure the following:
• Tests are included for any new functionality, logic changes or bug fixes.
• The PR aligns with our contribution guidelines.

Regarding new nodes:
We no longer accept new nodes directly into the core codebase. Instead, we encourage contributors to follow our Community Node Submission Guide to publish nodes independently.

If your node integrates with an AI service that you own or represent, please email nodes@n8n.io and we will be happy to discuss the best approach.

About review timelines:
This PR has been added to our internal tracker as "GHC-6172". While we plan to review it, we are currently unable to provide an exact timeframe. Our goal is to begin reviews within a month, but this may change depending on team priorities. We will reach out when the review begins.

Thank you again for contributing to n8n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments