-
Notifications
You must be signed in to change notification settings - Fork 54.5k
feat: Add ZenMux Chat Model node #23895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hey @888-wzk, Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request. Before we can proceed, please ensure the following: Regarding new nodes: If your node integrates with an AI service that you own or represent, please email [email protected] and we will be happy to discuss the best approach. About review timelines: Thank you again for contributing to n8n. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 6 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/@n8n/nodes-langchain/nodes/llms/LmChatZenMux/LmChatZenMux.node.ts">
<violation number="1" location="packages/@n8n/nodes-langchain/nodes/llms/LmChatZenMux/LmChatZenMux.node.ts:215">
P2: Rule violated: **Prefer Typeguards over Type casting**
Using `as string` for type narrowing violates the type safety rule. Consider using a type annotation with a type guard, or if `getNodeParameter` supports generics, use the generic parameter instead. While this pattern exists elsewhere in the codebase, the rule explicitly prohibits type narrowing with `as`.</violation>
<violation number="2" location="packages/@n8n/nodes-langchain/nodes/llms/LmChatZenMux/LmChatZenMux.node.ts:217">
P2: Rule violated: **Prefer Typeguards over Type casting**
Using `as { ... }` for type narrowing violates the type safety rule. Consider defining a proper interface for the options type and using a type guard function to validate the shape at runtime, or use a type annotation if the return type is compatible.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Summary
ZenMux is the world’s first enterprise-grade large model aggregation platform with an insurance payout mechanism. The platform provides one-stop access to the latest models across providers.
Added support for new LLM provider:
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)