Skip to content

fix(editor): Hide credential modal for r2r workflows (no-changelog)#23918

Closed
romeobalta wants to merge 5 commits intomasterfrom
gro-ready-to-run-modal-disable
Closed

fix(editor): Hide credential modal for r2r workflows (no-changelog)#23918
romeobalta wants to merge 5 commits intomasterfrom
gro-ready-to-run-modal-disable

Conversation

@romeobalta
Copy link
Contributor

Summary

Disables the auto-open behavior of the credential setup modal when inserting a workflow via the "Try an AI workflow" button.

Changes:

  • Added skipCredentialAutoOpen query parameter when navigating from "Try an AI workflow"
  • The flag is passed through to workflow metadata
  • SetupWorkflowCredentialsButton checks this flag and skips auto-opening the modal

Behavior:

  • The credential setup modal no longer auto-opens for "Try an AI workflow" flows
  • The setup button remains visible so users can manually open the modal if needed
  • Other template flows are unaffected

Related Linear tickets, Github issues, and Community forum posts

GRO-111

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...itor-ui/src/app/composables/useCanvasOperations.ts 14.28% 6 Missing ⚠️
...ages/frontend/editor-ui/src/app/views/NodeView.vue 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 6, 2026
@currents-bot
Copy link

currents-bot bot commented Jan 6, 2026

E2E Tests: n8n tests failed after 7m 43.3s

🟢 608 · 🔴 1 · ⚪️ 38 · 🟣 3

View Run Details

Run Details

  • Project: n8n

  • Groups: 2

  • Framework: Playwright

  • Run Status: Failed

  • Commit: 0e40a1d

  • Spec files: 142

  • Overall tests: 647

  • Duration: 7m 43.3s

  • Parallelization: 16

Failed Spec Files

Spec File Failures
tests/e2e/cloud/cloud.spec.ts 1

Groups

GroupId Results Spec Files Progress
multi-main:e2e 🟢 552 · 🔴 0 · ⚪️ 38 · 🟣 3 133 / 133
multi-main:e2e:isolated 🟢 56 · 🔴 1 · ⚪️ 0 9 / 9


This message was posted automatically by currents.dev | Integration Settings

@blacksmith-sh
Copy link

blacksmith-sh bot commented Jan 8, 2026

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
tests/e2e/cloud/cloud.spec.ts/
Cloud @db:reset @auth:owner › Easy AI workflow experiment › should show default instruc
tions if free AI credits experiment is control
View Logs

Fix in Cursor

@romeobalta romeobalta closed this Jan 12, 2026
@romeobalta romeobalta deleted the gro-ready-to-run-modal-disable branch January 12, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant