Skip to content

fix(core): Coerce BinaryDataConfig dbMaxFileSizeSchema to a number#23927

Merged
ivov merged 5 commits inton8n-io:masterfrom
davidpanic:master
Jan 7, 2026
Merged

fix(core): Coerce BinaryDataConfig dbMaxFileSizeSchema to a number#23927
ivov merged 5 commits inton8n-io:masterfrom
davidpanic:master

Conversation

@davidpanic
Copy link
Contributor

@davidpanic davidpanic commented Jan 6, 2026

Summary

This is a fix for issue #23919. The environment variable N8N_BINARY_DATA_DATABASE_MAX_FILE_SIZE now works correctly.

Related Linear tickets, Github issues, and Community forum posts

fixes #23919

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@n8n-assistant n8n-assistant bot added community Authored by a community member core Enhancement outside /nodes-base and /editor-ui in linear Issue or PR has been created in Linear for internal review labels Jan 6, 2026
@n8n-assistant
Copy link
Contributor

n8n-assistant bot commented Jan 6, 2026

Hey @davidpanic,

Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request.

Before we can proceed, please ensure the following:
• Tests are included for any new functionality, logic changes or bug fixes.
• The PR aligns with our contribution guidelines.

Regarding new nodes:
We no longer accept new nodes directly into the core codebase. Instead, we encourage contributors to follow our Community Node Submission Guide to publish nodes independently.

If your node integrates with an AI service that you own or represent, please email nodes@n8n.io and we will be happy to discuss the best approach.

About review timelines:
This PR has been added to our internal tracker as "GHC-6189". While we plan to review it, we are currently unable to provide an exact timeframe. Our goal is to begin reviews within a month, but this may change depending on team priorities. We will reach out when the review begins.

Thank you again for contributing to n8n.

ivov
ivov previously approved these changes Jan 6, 2026
Copy link
Member

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidpanic Thank you very much for spotting and fixing this. Added a few tests to prevent regressions.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ivov ivov merged commit 565a428 into n8n-io:master Jan 7, 2026
27 checks passed
@n8n-assistant n8n-assistant bot mentioned this pull request Jan 12, 2026
@n8n-assistant
Copy link
Contributor

n8n-assistant bot commented Jan 12, 2026

Got released with n8n@2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Authored by a community member core Enhancement outside /nodes-base and /editor-ui in linear Issue or PR has been created in Linear for internal review Released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid value for N8N_BINARY_DATA_DATABASE_MAX_FILE_SIZE - Expected number, received string. Falling back to default value.

3 participants