-
Notifications
You must be signed in to change notification settings - Fork 54.4k
feat(ai-builder): Prefer core nodes over code node #23937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 7 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/configurator.prompt.ts">
<violation number="1" location="packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/configurator.prompt.ts:61">
P1: Expression syntax missing `=` prefix. All examples in this section use `{{ }}` but should use `={{ }}` to match the rest of the file and n8n's actual expression syntax. For example, `{{ /pattern/.test($json.text) }}` should be `={{ /pattern/.test($json.text) }}`.
This could cause the AI configurator to generate incorrect expressions that won't be evaluated by n8n.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| const EXPRESSION_TECHNIQUES = `Expressions support JavaScript methods - no Code node needed for common operations: | ||
|
|
||
| Regex operations: | ||
| - Test pattern: {{ /pattern/.test($json.text) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: Expression syntax missing = prefix. All examples in this section use {{ }} but should use ={{ }} to match the rest of the file and n8n's actual expression syntax. For example, {{ /pattern/.test($json.text) }} should be ={{ /pattern/.test($json.text) }}.
This could cause the AI configurator to generate incorrect expressions that won't be evaluated by n8n.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/configurator.prompt.ts, line 61:
<comment>Expression syntax missing `=` prefix. All examples in this section use `{{ }}` but should use `={{ }}` to match the rest of the file and n8n's actual expression syntax. For example, `{{ /pattern/.test($json.text) }}` should be `={{ /pattern/.test($json.text) }}`.
This could cause the AI configurator to generate incorrect expressions that won't be evaluated by n8n.</comment>
<file context>
@@ -55,6 +55,30 @@ Examples in parameter configuration:
+const EXPRESSION_TECHNIQUES = `Expressions support JavaScript methods - no Code node needed for common operations:
+
+Regex operations:
+- Test pattern: {{ /pattern/.test($json.text) }}
+- Extract match: {{ $json.text.match(/pattern/)?.[1] }}
+- Replace text: {{ $json.text.replace(/pattern/, 'replacement') }}
</file context>
✅ Addressed in 8cfff28
|
E2E Tests: n8n tests passed after 9m 24.5s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
|
@mutdmour Can you please check if we can remove the similar instructions from data-transformation best practice? |
|
@burivuhster good point. Maybe since data transformation is not always applied, we should remove it from there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 25 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/frontend/@n8n/design-system/src/components/AskAssistantChat/messages/ThinkingMessage.test.ts">
<violation number="1">
P2: This assertion could give a false positive if the element doesn't exist. When `statusText` is null, `statusText?.className` is undefined, and `expect(undefined).not.toContain('shimmer')` passes. Add an existence check before the negative assertion.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 20 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/cli/test/integration/eventbus/README-manual-test-syslog.md">
<violation number="1">
P2: Incomplete sentence - this line appears to be truncated. The sentence ends with "improved in" but doesn't complete the thought.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
burivuhster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, feel free to disregard minor comments as long as eval scores are fine
packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/discovery.prompt.ts
Show resolved
Hide resolved
packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/discovery.prompt.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/configurator.prompt.ts">
<violation number="1" location="packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/configurator.prompt.ts:115">
P1: Malformed JSON in prompt example - missing closing quote and extra braces. This line has `}}}}` (4 closing braces) instead of `}}`, and is missing the closing `",`. Should be `"={{ $json.fieldName }}",` to match the pattern used in all other expression changes.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/configurator.prompt.ts
Outdated
Show resolved
Hide resolved
…urator.prompt.ts Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
|
Got released with |
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)