Skip to content

Conversation

@mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Jan 6, 2026

Summary

  • Update discovery prompt to prefer core nodes over code node
  • Add support for dataset splits in node
  • Add saving for generated workflows in langsmith runs

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@mutdmour mutdmour marked this pull request as ready for review January 6, 2026 16:14
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 6, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 7 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/configurator.prompt.ts">

<violation number="1" location="packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/configurator.prompt.ts:61">
P1: Expression syntax missing `=` prefix. All examples in this section use `{{ }}` but should use `={{ }}` to match the rest of the file and n8n&#39;s actual expression syntax. For example, `{{ /pattern/.test($json.text) }}` should be `={{ /pattern/.test($json.text) }}`.

This could cause the AI configurator to generate incorrect expressions that won&#39;t be evaluated by n8n.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

const EXPRESSION_TECHNIQUES = `Expressions support JavaScript methods - no Code node needed for common operations:

Regex operations:
- Test pattern: {{ /pattern/.test($json.text) }}
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Expression syntax missing = prefix. All examples in this section use {{ }} but should use ={{ }} to match the rest of the file and n8n's actual expression syntax. For example, {{ /pattern/.test($json.text) }} should be ={{ /pattern/.test($json.text) }}.

This could cause the AI configurator to generate incorrect expressions that won't be evaluated by n8n.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/configurator.prompt.ts, line 61:

<comment>Expression syntax missing `=` prefix. All examples in this section use `{{ }}` but should use `={{ }}` to match the rest of the file and n8n&#39;s actual expression syntax. For example, `{{ /pattern/.test($json.text) }}` should be `={{ /pattern/.test($json.text) }}`.

This could cause the AI configurator to generate incorrect expressions that won&#39;t be evaluated by n8n.</comment>

<file context>
@@ -55,6 +55,30 @@ Examples in parameter configuration:
+const EXPRESSION_TECHNIQUES = `Expressions support JavaScript methods - no Code node needed for common operations:
+
+Regex operations:
+- Test pattern: {{ /pattern/.test($json.text) }}
+- Extract match: {{ $json.text.match(/pattern/)?.[1] }}
+- Replace text: {{ $json.text.replace(/pattern/, &#39;replacement&#39;) }}
</file context>

✅ Addressed in 8cfff28

@currents-bot
Copy link

currents-bot bot commented Jan 6, 2026

E2E Tests: n8n tests passed after 9m 24.5s

🟢 609 · 🔴 0 · ⚪️ 38 · 🟣 2

View Run Details

Run Details

  • Project: n8n

  • Groups: 2

  • Framework: Playwright

  • Run Status: Passed

  • Commit: d6d8367

  • Spec files: 142

  • Overall tests: 647

  • Duration: 9m 24.5s

  • Parallelization: 16

Groups

GroupId Results Spec Files Progress
multi-main:e2e 🟢 552 · 🔴 0 · ⚪️ 38 · 🟣 2 133 / 133
multi-main:e2e:isolated 🟢 57 · 🔴 0 · ⚪️ 0 9 / 9


This message was posted automatically by currents.dev | Integration Settings

@mutdmour mutdmour requested review from a team and schrothbn and removed request for a team January 7, 2026 13:50
@burivuhster
Copy link
Contributor

@mutdmour Can you please check if we can remove the similar instructions from data-transformation best practice?

@mutdmour
Copy link
Contributor Author

mutdmour commented Jan 7, 2026

@burivuhster good point. Maybe since data transformation is not always applied, we should remove it from there.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 25 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/frontend/@n8n/design-system/src/components/AskAssistantChat/messages/ThinkingMessage.test.ts">

<violation number="1">
P2: This assertion could give a false positive if the element doesn't exist. When `statusText` is null, `statusText?.className` is undefined, and `expect(undefined).not.toContain('shimmer')` passes. Add an existence check before the negative assertion.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@mutdmour mutdmour requested a review from burivuhster January 7, 2026 15:36
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 20 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/cli/test/integration/eventbus/README-manual-test-syslog.md">

<violation number="1">
P2: Incomplete sentence - this line appears to be truncated. The sentence ends with "improved in" but doesn't complete the thought.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

burivuhster
burivuhster previously approved these changes Jan 7, 2026
Copy link
Contributor

@burivuhster burivuhster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to disregard minor comments as long as eval scores are fine

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/configurator.prompt.ts">

<violation number="1" location="packages/@n8n/ai-workflow-builder.ee/src/prompts/agents/configurator.prompt.ts:115">
P1: Malformed JSON in prompt example - missing closing quote and extra braces. This line has `}}}}` (4 closing braces) instead of `}}`, and is missing the closing `",`. Should be `"={{ $json.fieldName }}",` to match the pattern used in all other expression changes.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

mutdmour and others added 3 commits January 7, 2026 17:04
…urator.prompt.ts

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@mutdmour mutdmour requested a review from burivuhster January 7, 2026 16:07
@mutdmour mutdmour merged commit 4e6063c into master Jan 7, 2026
40 checks passed
@mutdmour mutdmour deleted the ai-1802 branch January 7, 2026 16:23
@n8n-assistant n8n-assistant bot mentioned this pull request Jan 12, 2026
@n8n-assistant
Copy link
Contributor

n8n-assistant bot commented Jan 12, 2026

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team Released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants