Skip to content

Conversation

@milkshakeuk
Copy link
Member

@milkshakeuk milkshakeuk commented Apr 7, 2025

See #678 for the details.

@milkshakeuk milkshakeuk changed the title fixa security vulnerability with a transitive dependency fix security vulnerability with a transitive dependency Apr 7, 2025
@milkshakeuk milkshakeuk requested a review from Copilot April 7, 2025 12:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • build/nHapi.v3.nuspec: Language not supported
  • src/NHapi.Base/NHapi.Base.csproj: Language not supported
  • tests/NHapi.Base.NUnit/NHapi.Base.NUnit.csproj: Language not supported

@milkshakeuk milkshakeuk requested a review from AMCN41R April 7, 2025 12:45
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

Unit Test Results

    5 files      5 suites   9s ⏱️
1 431 tests 1 343 ✅  88 💤 0 ❌
2 692 runs  2 588 ✅ 104 💤 0 ❌

Results for commit e8fb6f4.

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ac87584) 1020600 22935 2.25%
Head commit (e8fb6f4) 1020600 (+0) 22935 (+0) 2.25% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#684) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@AMCN41R
Copy link
Collaborator

AMCN41R commented Apr 7, 2025

lgtm 👍

@milkshakeuk milkshakeuk merged commit a3531a2 into master Apr 7, 2025
15 checks passed
@milkshakeuk milkshakeuk deleted the bug/fixes678 branch April 7, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transient Dependency on System.Drawing.Common v5.0.0 with Critical Vulnerability in nHapi 3.2.2

3 participants