Skip to content

增加业务校验异常errorCode=403处理 #619 #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yesAnd92 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

增加业务校验异常errorCode=403处理 #619 #626

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e42dac
增加errorCode=403处理
yesAnd92 Jun 20, 2023
e82195f
优化naocs服务端响应的错误码处理
yesAnd92 Jun 27, 2023
b5d9c4b
注册中心批量注册&更新注册信息增加参数校验
yesAnd92 Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions clients/config_client/config_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,14 @@ func (client *ConfigClient) getConfigInner(param vo.ConfigParam) (content string
response, err := client.configProxy.queryConfig(param.DataId, param.Group, clientConfig.NamespaceId,
clientConfig.TimeoutMs, false, client)
if err != nil {
if _, ok := err.(*nacos_error.NacosError); ok {
nacosErr := err.(*nacos_error.NacosError)

if nacosErr.ErrorCode() == "403" {
return "", errors.New(nacosErr.Error())
}
}

logger.Errorf("get config from server error:%v, dataId=%s, group=%s, namespaceId=%s", err,
param.DataId, param.Group, clientConfig.NamespaceId)

Expand Down
12 changes: 12 additions & 0 deletions clients/config_client/config_proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package config_client
import (
"context"
"encoding/json"
"github.com/nacos-group/nacos-sdk-go/v2/common/nacos_error"
"net/http"
"strconv"
"time"
Expand Down Expand Up @@ -62,6 +63,11 @@ func (cp *ConfigProxy) requestProxy(rpcClient *rpc.RpcClient, request rpc_reques
signHeaders := nacos_server.GetSignHeadersFromRequest(request.(rpc_request.IConfigRequest), cp.clientConfig.SecretKey)
request.PutAllHeaders(signHeaders)
response, err := rpcClient.Request(request, int64(timeoutMills))
if response != nil && response.GetErrorCode() == 403 {
logger.Debugf(
"[config_rpc_client] [sub-server-error] request being forbidden, reason: %s", response.GetMessage())
return nil, nacos_error.NewNacosError("403", "request being forbidden, reason: "+response.GetMessage(), nil)
}
monitor.GetConfigRequestMonitor(constant.GRPC, request.GetRequestType(), rpc_response.GetGrpcResponseStatusCode(response)).Observe(float64(time.Now().Nanosecond() - start.Nanosecond()))
return response, err
}
Expand Down Expand Up @@ -143,6 +149,12 @@ func (cp *ConfigProxy) queryConfig(dataId, group, tenant string, timeout uint64,
return nil, errors.New("data being modified, dataId=" + dataId + ",group=" + group + ",tenant=" + tenant)
}

if response.GetErrorCode() == 403 {
logger.Debugf(
"[config_rpc_client] [sub-server-error] get server config being forbidden, reason: %s", response.GetMessage())
return nil, nacos_error.NewNacosError("403", "get server config being forbidden, reason: "+response.GetMessage(), nil)
}

if response.GetErrorCode() > 0 {
logger.Errorf("[config_rpc_client] [sub-server-error] dataId=%s, group=%s, tenant=%s, code=%+v", dataId, group,
tenant, response)
Expand Down