Skip to content

use redo service instead of connection event listener#710

Open
sodaRyCN wants to merge 4 commits intonacos-group:masterfrom
sodaRyCN:feature_redo_service
Open

use redo service instead of connection event listener#710
sodaRyCN wants to merge 4 commits intonacos-group:masterfrom
sodaRyCN:feature_redo_service

Conversation

@sodaRyCN
Copy link
Contributor

as title describe , and change api

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (389f6b6) 32.69% compared to head (3d8eba2) 36.94%.

❗ Current head 3d8eba2 differs from pull request most recent head bf880f8. Consider uploading reports for the commit bf880f8 to get more accurate results

Files Patch % Lines
...nts/naming_client/naming_grpc/naming_grpc_proxy.go 0.00% 43 Missing ⚠️
clients/naming_client/naming_grpc/redo_service.go 80.80% 17 Missing and 7 partials ⚠️
clients/naming_client/naming_grpc/redo.go 87.67% 6 Missing and 3 partials ⚠️
clients/naming_client/naming_client.go 22.22% 7 Missing ⚠️
...nts/naming_client/naming_http/naming_http_proxy.go 0.00% 7 Missing ⚠️
clients/cache/simple_cache.go 93.68% 3 Missing and 3 partials ⚠️
...s/naming_client/naming_cache/subscribe_callback.go 80.00% 3 Missing and 1 partial ⚠️
clients/naming_client/naming_proxy_delegate.go 0.00% 3 Missing ⚠️
.../naming_client/naming_cache/service_info_holder.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   32.69%   36.94%   +4.25%     
==========================================
  Files          45       47       +2     
  Lines        3294     3551     +257     
==========================================
+ Hits         1077     1312     +235     
- Misses       2136     2147      +11     
- Partials       81       92      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants