Open
Conversation
|
joseph seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
binbin0325
requested changes
May 14, 2024
Member
binbin0325
left a comment
binbin0325
left a comment
There was a problem hiding this comment.
可以新建一个issue，详细描述下 当前pr要解决的需求或问题。
Author
|
其实就是感觉可以用option来加参 或者hook 方便自定义做balance 或者过滤instance
获取 Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: binbin.zhang ***@***.***>
发送时间: Tuesday, May 14, 2024 10:15:52 AM
收件人: nacos-group/nacos-sdk-go ***@***.***>
抄送: Joseph Wang ***@***.***>; Author ***@***.***>
主题: Re: [nacos-group/nacos-sdk-go] 📦 NEW: add discover options (PR #752)
@binbin0325 requested changes on this pull request.
可以新建一个issue，详细描述下 当前pr要解决的需求或问题。
—
Reply to this email directly, view it on GitHub<#752 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGASDXN65CBVVW5224T2ZVTZCFXVRAVCNFSM6AAAAABHQN5AM2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJUGEZDMNBQHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
binbin0325
reviewed
May 27, 2024
Member
binbin0325
left a comment
binbin0325
left a comment
There was a problem hiding this comment.
建议参考INamingClient 中的 SelectInstances，SelectAllInstances 等实现方式，保持用法一致。便于用户理解
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add discover options