fix(auth): ensure endpoint-mode login after server list refresh + add regression test (#728)#856
Draft
ljluestc wants to merge 2 commits intonacos-group:masterfrom
Draft
fix(auth): ensure endpoint-mode login after server list refresh + add regression test (#728)#856ljluestc wants to merge 2 commits intonacos-group:masterfrom
ljluestc wants to merge 2 commits intonacos-group:masterfrom
Conversation
…nacos-group#728)\n\n- Mocks address server discovery\n- Verifies login uses discovered server list\n- Ensures accessToken is injected into subsequent requests
|
|
…es (nacos-group#728)\n\n- Call securityLogin.Login() right after UpdateServerList in refresh\n- Ensures token is acquired promptly in endpoint/address mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes and tests endpoint/address-mode authentication.
Problem (#728): In endpoint mode, login could return false if the discovered serverList was not present at login time, causing 403 on instance registration.
Changes:
Why this is safe:
How to verify:
Fixes #728