Skip to content

Add nuanze endpoints - #450

Merged
frankinkfnd merged 5 commits into
mainfrom
feat/nuanze-endpoints
Aug 31, 2026
Merged

Add nuanze endpoints#450
frankinkfnd merged 5 commits into
mainfrom
feat/nuanze-endpoints

Conversation

@przemekink

Copy link
Copy Markdown
Contributor

No description provided.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@przemekink

Copy link
Copy Markdown
Contributor Author

@claude review once

Comment thread packages/nuanze-client/src/NuanzeClient.ts Outdated
Base automatically changed from feat/nuanze-client to main August 26, 2026 12:35
@przemekink
przemekink requested a review from frankinkfnd August 27, 2026 10:11
@frankinkfnd

Copy link
Copy Markdown
Contributor

@claude review once

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no new issues

No new issues were found in this update; 1 finding from earlier reviews is still open above.

@frankinkfnd frankinkfnd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For getLeaderboard and getFollowedLeaderboard, maybe we can have a view_as: <SubaccountHex> parameter (same as backend). When provided, the subaccount's current position is returned in another field

Comment thread packages/nuanze-client/src/NuanzeClient.ts Outdated
/**
* Params for `NuanzeClient.getMarketPositions`. Resolves only an active perpetual.
*/
export interface GetNuanzeMarketPositionsParams {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we sort by pnl, size, etc?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

}

/**
* Lists open perpetual position legs for the resolved market, ordered by absolute notional

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the home screen we need the top PnL positions:

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does it mean? Closed position with it's PnL, unrealized PnL and live position? All markets?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now open positions from public profiles with highest pnl: https://ink-foundation.slack.com/archives/C0B76GBKDKM/p1786637521020219?thread_ts=1786580079.543059&channel=C0B76GBKDKM&message_ts=1786637521.020219

But feel free to suggest whatever is easiest

* Gets the deployed OpenAPI 3.1 document. Immutable for a release and cached for 300 seconds
* with ETag.
*/
async getOpenApiDocument(): Promise<GetNuanzeOpenApiDocumentResponse> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@przemekink what's the purpose of this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@frankinkfnd

Copy link
Copy Markdown
Contributor

What about market skew?

@przemekink

Copy link
Copy Markdown
Contributor Author

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@frankinkfnd
frankinkfnd merged commit 08eb7d9 into main Aug 31, 2026
3 of 4 checks passed
@frankinkfnd
frankinkfnd deleted the feat/nuanze-endpoints branch August 31, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants