Migrate default endpoints to unified api.{env}.nado.xyz API - #453
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
frankinkfnd
approved these changes
Aug 28, 2026
| // Server base URL, without a version segment (ex. `https://api.prod.nado.xyz/archive`) | ||
| url: string; | ||
| // Rewards service base URL, including the version segment (ex. `https://api.prod.nado.xyz/rewards/v1`). | ||
| // Defaults to `${url}/rewards/v1`. |
Contributor
There was a problem hiding this comment.
Maybe we should make this required?
Contributor
Author
There was a problem hiding this comment.
Probably not worth it, I kept it for smoothing/derisking migration in case anyone uses a custom endpoint for this - after a while we could just have this work exactly like other services.
Only reason it looks a bit different, compared to other services, is that rewards was kinda hybrid as an "extension" of archive before unified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend launched a unified API host (
api.{env}.nado.xyz/{service}) for all public services. This migrates the SDK's default endpoints off the per-service hosts (gateway.test.nado.xyz,archive.prod.nado.xyz, etc.). Old endpoints still work; this just moves our defaults forward.Heads up:
MobileClientrequest paths changed from${url}/mobile/execute→${url}/execute(service/version now live in the base URL, e.g..../mobile/v1). If you pass a custom mobile URL, it must now include/mobile/v1. Same applies to thelocaldefault (...:8004/v1/mobile).IndexerClientOpts.rewardsUrlandrewardsEndpointoncreateNadoClientcustom-endpoint opts. Both fall back to${indexerEndpoint}/rewards/v1(the old topology), so existing custom-endpoint setups keep working.