load diff for inspection#6
Draft
nagilson wants to merge 7 commits intonagilson-global-sdk-installfrom
Draft
Conversation
…hich causes every command on the sample extension to fail
The sample extension needs a license to be packed without warning, so I copied the license over to its folder The debugging has a prototype logger to log to a C: log file. It still needs more testing.
newer versions of p-retry use es6 syntax vscode doesnt support, so it will fail to run we had to downgrade it we also added to the output stream observer to try to get vscode to output debug messages
the registry key lookup was not working on 32 bit machines node could not resolve system root the install location was different than I expected and the registry keys are stored in a different location in addition, during refactor for the linter I forgot to remove the ' in one of the strings causing failure todo: see on win32 why an existing install does not return 0. It might be because of the reg key error
…t use .exe or any 1 dotnet file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.