Draft
Conversation
…o nagilson-global-compliance
Sudo is required to use wget to add the feed and such, also it was trying to run split on an array which doesnt work improves wsl error message to include docs adds telemetry boilerplate code
…son/vscode-dotnet-runtime into nagilson-global-compliance
sudo is needed for this to pass in all cases
- the shell option is needed for spawn to access windows shell commands, exec does this by default but exec does not capture detailed output streams - fix a timeout where ms was used as seconds - note that you need to restart for telemetry notice to change
build machines are failing because they cannot find vscode, even though it is an implicit module because it is part of the engine, so lets try adding it explicitly so it downloads the module
This reverts commit 76900c1.
This is not possible without figuring out what shell the user has and which profile is loaded, then editing their profile file, and reloading the shell
it cannot find vscode which is the engine, it should be able to do so, seems like a node bug, it finds it on my machine.
the vscode update now requires this property to be defined in the interface, but it is not used by us, so this should be ok
The process environment is for the extension host, which is separate from the vscode terminal environment. That needs to be edited as well, which we now do here.
'vscode' cannot be referenced outside of code that's directly part of an extension. So wrapper classes are necessary to access the vscode ui api, or the environment, or the extension context environment. If referencing a file that references these types the build will pass but tests will fail to execute. The utility context is where things like this will go in the future. Some of these objects must be created before the acquisition context can be ready and it is best to have some 'global' state for utilities. File Utilities could probably go there in the future as well. It is an ugly hack but the best option. Note the runtime extension test is timing out, which I am investigating.
This reverts commit 04d189b.
…he new vscode version" This reverts commit 465256b.
This reverts commit 95d9e21.
This reverts commit d2c9a6f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.