fix: correct logic for the WithInPlaceRestore and WithPlaceRestore options#211
Open
AnyCPU wants to merge 1 commit intonakagami:masterfrom
Open
fix: correct logic for the WithInPlaceRestore and WithPlaceRestore options#211AnyCPU wants to merge 1 commit intonakagami:masterfrom
AnyCPU wants to merge 1 commit intonakagami:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the WithInPlaceRestore option sets InPlaceRestore = false and
the WithPlaceRestore options sets InPlaceRestore = true.
corresponding boolean values are swapped relative to their function names.
this means calling WithInPlaceRestore() actually prevents the isc_spb_nbk_inplace flag from being sent to Firebird, which is the opposite of what callers expect.
FIX
update code and related test to use the correct function name for enabling in-place restore.