fix: chain registry search all chains#2272
Open
chetankashetti wants to merge 2 commits intonamada-net:mainfrom
Open
fix: chain registry search all chains#2272chetankashetti wants to merge 2 commits intonamada-net:mainfrom
chetankashetti wants to merge 2 commits intonamada-net:mainfrom
Conversation
- Updated `getChainRegistryByChainName` to first search in IBC chains and fallback to Namada chains. - Introduced a new test suite for integration functions, covering various scenarios for chain registry retrieval, RPC and REST API access, and IBC asset handling. - Added tests to ensure correct behavior for both existing and non-existent chains, as well as prioritization of IBC chains over Namada chains.
chetankashetti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #2240 by updating the
getChainRegistryByChainNamefunction to search ALL chains instead of just IBC chains.Changes
getChainRegistryByChainNameto search both IBC chains and Namada chainsTesting
Fixes #2240