fix: resolve SQL ambiguous column reference in apps API filtering#688
Merged
fix: resolve SQL ambiguous column reference in apps API filtering#688
Conversation
Coverage ReportIlc/serverCommit SHA:49bd4d07c2089938fbf35798e2a3bf6b52dd3740 Test coverage results 🧪File details
Ilc/clientCommit SHA:49bd4d07c2089938fbf35798e2a3bf6b52dd3740 Test coverage results 🧪File details
RegistryCommit SHA:49bd4d07c2089938fbf35798e2a3bf6b52dd3740 Test coverage results 🧪File details
|
stas-nc
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
When filtering apps with both q (name search) and domainId parameters, the query joins route_slots table which also has a name column. This caused an "ambiguous column reference" SQL
error.
Root cause:
// Before - ambiguous 'name' column
query.whereIn('name', [...]);
query.where('name', 'like',
%${filters.q}%);Fix:
// After - qualified with table name
query.whereIn(
${Tables.Apps}.name, [...]);query.where(
${Tables.Apps}.name, 'like',%${filters.q}%);