Conversation
Coverage ReportIlc/serverCommit SHA:ab585fae1014fcbba9d58e090f7a7a79b7c5ffdd Test coverage results 🧪File details
Ilc/clientCommit SHA:ab585fae1014fcbba9d58e090f7a7a79b7c5ffdd Test coverage results 🧪File details
RegistryCommit SHA:ab585fae1014fcbba9d58e090f7a7a79b7c5ffdd Test coverage results 🧪File details
|
stas-nc
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements NPF-2378 for apps by adding
domainAliassupport alongside the existingenforceDomainfield.Apps can now be authored with a stable router-domain alias instead of an environment-specific numeric domain ID. The alias is resolved on write and stored in the existing
apps.enforceDomainrelation, so embedded apps continue to use the current domain-restriction flow without any schema change inapps.What Changed
domainAliasto app DTO/schema validation.domainAliasandenforceDomainmutually exclusive for apps.enforceDomainon unrelated partial app updates.resolveDomainAliastypings:Omit<T, 'domainAlias'>domainIdRoutesServicehelper input types to reflect the normalized route shape after alias resolution.docs/multi-domains.md.Why
domainIdis generated in Registry and may differ between environments, which makes manifests and config harder to read and less portable. SupportingdomainAliasgives developers a stable cross-environment identifier while keeping the existing storage model and runtime behavior.Notes
router_domains.aliasfield andapps.enforceDomain.domainAliasare normalized into the existing domain-restriction mechanism.