Handle SIGINT/SIGTERM to allow graceful shutdown#28
Merged
annervisser merged 1 commit intomainfrom Feb 10, 2026
Merged
Conversation
The root context was created with context.Background() and no signal handling, so interrupt signals (Ctrl+C, GitHub Actions cancellation) were ignored. Use signal.NotifyContext to cancel the context on SIGINT and SIGTERM, allowing all subcommands to shut down gracefully. Also update authorized-users list in CI workflows. Amp-Thread-ID: https://ampcode.com/threads/T-019c47f1-15d3-72ff-bdbd-9148e7131838 Co-authored-by: Amp <amp@ampcode.com>
n-g
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The breakpoint CLI ignored interrupt signals (SIGINT/SIGTERM) because the root context was a plain
context.Background()with no signal handling. This meant Ctrl+C and GitHub Actions cancellation had no effect — the process would keep running until the timer expired.Fix
Use
signal.NotifyContextinmain.goto cancel the root context on SIGINT and SIGTERM. This propagates through all subcommands (wait,hold, etc.) via their<-ctx.Done()selects.