Closed
Conversation
Owner
|
Applied it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix out-of-bounds read in smb_locking_andx()
The Locks field in struct smb_com_lock_req is declared as an array of pointers (
char *Locks[1]), which gives it typechar **.This causes pointer arithmetic on req->Locks to scale by sizeof(char *) (8 bytes on 64-bit) instead of by 1 byte.
In smb_locking_andx(), the code computes unlock element pointers as:
req->Locks + (sizeof(struct locking_andx_range64) * lock_count)With the current
char **type, this advances by 8x the intended offset, reading far beyond the request buffer into adjacent kernel memory.Fix by declaring Locks as
char Locks[1]so that pointer arithmetic operates at byte granularity, matching the intended behavior.