Upgrades theme-ui to the latest version#82
Upgrades theme-ui to the latest version#82cmaycumber wants to merge 4 commits intonandorojo:masterfrom
Conversation
|
Some breaking changes I've found:
Will list more that I find outside of the changelog. |
|
Here's a thought: Could we detach fully from theme-ui? It's only used for 2 things:
For 1, could push a breaking change, that requires users to use For 2, we could just have a I also noticed that This way, we'd only need I've been a bit disillusioned that |
I'm interested in this change as well. Should we just close this PR and try to open one that's more in line with this approach? |
|
Yeah I think that makes sense |
|
Once we do "detach" from theme UI, this would be my favorite feature to implement: system-ui/theme-ui#1090 I wonder if we could cherry pick some of the logic from that PR into Dripsy. One goal would be to keep it simpler. There would be no magic styles when creating the theme itself; only on the actual Also relevant to #72 |
Yeah, that would be awesome. Going to close this now. |
If I start on this, do you have any direction you want to take? Should we try to mock the latest API used by theme-ui or just start replacing each piece of the current API we're using with |
Upgrades
theme-uito the latest version.Solves: #68