Accept closures in Builder methods (e.g. new, view, update, etc.)#937
Open
vhfmag wants to merge 4 commits intonannou-org:masterfrom
Open
Accept closures in Builder methods (e.g. new, view, update, etc.)#937vhfmag wants to merge 4 commits intonannou-org:masterfrom
Builder methods (e.g. new, view, update, etc.)#937vhfmag wants to merge 4 commits intonannou-org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a variation of what @thinkrapido implemented in #899 (and is based on it), but it stores closures in
Boxinstead ofArc(which was already done in #815 for WASM support), and allows nannou consumers to pass closures directly toBuildermethods, without wrapping them inArcor using a macro.To achieve that in a convenient way, it uses the trait_set macro, which enables us to use trait aliases without requiring nightly Rust. That's more convenient because it allows us to do e.g.
trait ModelFn<Model> = 'static + Fn(&App) -> Model. Everything done here can be achieved without it, but we'd need to inline the definition of function types everywhere instead of importing aliases.Here's an example of what we can achieve when
Buildermethods accept closures:This closes #793