Skip to content

Update 1 NuGet dependencies #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Update 1 NuGet dependencies #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions nanoFramework.System.Net/System.Net.nfproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="Current" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="..\packages\Nerdbank.GitVersioning.3.6.143\build\Nerdbank.GitVersioning.props" Condition="Exists('..\packages\Nerdbank.GitVersioning.3.6.143\build\Nerdbank.GitVersioning.props')" />
<Import Project="..\packages\Nerdbank.GitVersioning.3.6.146\build\Nerdbank.GitVersioning.props" Condition="Exists('..\packages\Nerdbank.GitVersioning.3.6.146\build\Nerdbank.GitVersioning.props')" />
<PropertyGroup Label="Globals">
<NanoFrameworkProjectSystemPath>$(MSBuildExtensionsPath)\nanoFramework\v1.0\</NanoFrameworkProjectSystemPath>
</PropertyGroup>
Expand Down Expand Up @@ -155,8 +155,8 @@
<PropertyGroup>
<ErrorText>This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105.The missing file is {0}.</ErrorText>
</PropertyGroup>
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.3.6.143\build\Nerdbank.GitVersioning.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.3.6.143\build\Nerdbank.GitVersioning.props'))" />
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.3.6.143\build\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.3.6.143\build\Nerdbank.GitVersioning.targets'))" />
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.3.6.146\build\Nerdbank.GitVersioning.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.3.6.146\build\Nerdbank.GitVersioning.props'))" />
<Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.3.6.146\build\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.3.6.146\build\Nerdbank.GitVersioning.targets'))" />
</Target>
<Import Project="..\packages\Nerdbank.GitVersioning.3.6.143\build\Nerdbank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.3.6.143\build\Nerdbank.GitVersioning.targets')" />
<Import Project="..\packages\Nerdbank.GitVersioning.3.6.146\build\Nerdbank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.3.6.146\build\Nerdbank.GitVersioning.targets')" />
</Project>
2 changes: 1 addition & 1 deletion nanoFramework.System.Net/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
<package id="nanoFramework.System.IO.Streams" version="1.1.59" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Text" version="1.2.54" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Threading" version="1.1.32" targetFramework="netnano1.0" />
<package id="Nerdbank.GitVersioning" version="3.6.143" developmentDependency="true" targetFramework="netnano1.0" />
<package id="Nerdbank.GitVersioning" version="3.6.146" developmentDependency="true" targetFramework="netnano1.0" />
</packages>
6 changes: 3 additions & 3 deletions nanoFramework.System.Net/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
},
"Nerdbank.GitVersioning": {
"type": "Direct",
"requested": "[3.6.143, 3.6.143]",
"resolved": "3.6.143",
"contentHash": "N24MtdLq4PmdJ2woTQd9515q0I1jeO/DlimYCB/GoRd510Fc9dk9H6YaN8MPPrVF8RHrIalCUfWbWvcoarYeoQ=="
"requested": "[3.6.146, 3.6.146]",
"resolved": "3.6.146",
"contentHash": "W1eQ8hD9Y/cZ2+ilgxECl003xr1hybpN3fMxoTlMqg++BixETBMWzS4y9s08oHJKXgKtudsoxhITNOEf1OR66w=="
Comment on lines +37 to +39
Copy link

@coderabbitai coderabbitai bot Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Resolved version for Nerdbank.GitVersioning not updated as expected.

The resolved version for Nerdbank.GitVersioning is not set to "3.6.146" in nanoFramework.System.Net/packages.lock.json as intended. Please ensure that the version update is correctly applied.

  • Verify that "resolved": "3.6.146" is present under the "Nerdbank.GitVersioning" entry in packages.lock.json.
🔗 Analysis chain

Version update for Nerdbank.GitVersioning looks good.

The update of Nerdbank.GitVersioning from version 3.6.143 to 3.6.146 is consistent with the PR objectives. This change appears to be part of routine dependency management, as indicated in the PR summary.

To ensure consistency, let's verify that this is the only instance of Nerdbank.GitVersioning in the file:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify Nerdbank.GitVersioning version consistency

# Test: Search for Nerdbank.GitVersioning entries
# Expect: Only one entry with version 3.6.146
rg -i "Nerdbank.GitVersioning" nanoFramework.System.Net/packages.lock.json

Length of output: 108

Script:

#!/bin/bash
# Description: Verify that Nerdbank.GitVersioning is resolved to version 3.6.146

rg -i '"Nerdbank\.GitVersioning".*"resolved":\s*"3\.6\.146"' nanoFramework.System.Net/packages.lock.json

Length of output: 106

Script:

#!/bin/bash
# Description: Extract and verify the resolved version of Nerdbank.GitVersioning

# Step 1: Find the line with "Nerdbank.GitVersioning"
resolved_line=$(rg -i '"Nerdbank\.GitVersioning".*' nanoFramework.System.Net/packages.lock.json)

# Step 2: Extract the "resolved" version
resolved_version=$(echo "$resolved_line" | rg -o '"resolved":\s*"[^"]+"' | rg -o '[0-9]+\.[0-9]+\.[0-9]+')

# Step 3: Check if the resolved version is 3.6.146
if [ "$resolved_version" == "3.6.146" ]; then
  echo "Resolved version is correctly set to 3.6.146"
else
  echo "Resolved version is $resolved_version, expected 3.6.146"
fi

Length of output: 376

}
}
}
Expand Down