Fix check for max values inclusive for ssid and password #337

BoBoBaSs84 · 2025-01-25T13:55:53Z

Description

Validation of the wireless configuration fails if either the SSID is 32 characters long or the password is 64 characters long. By definition, however, these may have these respective lengths.

changes:

Throwing ArgumentOutOfRangeException only when the SSID length is greater than 32 characters.
throwing ArgumentOutOfRangeException only when the PASSWORD is greater than 64 characters.

Backed up on the native side here:

https://github.com/nanoframework/nf-interpreter/blob/main/src/HAL/Include/nanoHAL_Network.h#L268

and here:

https://github.com/nanoframework/nf-interpreter/blob/main/src/HAL/Include/nanoHAL_Network.h#L271

Motivation and Context

I did not raise an issue.

How Has This Been Tested?

See the discussion:

https://github.com/orgs/nanoframework/discussions/1594#discussioncomment-11946872

Screenshots

Types of changes

Improvement (non-breaking change that improves a feature, code or algorithm)
Bug fix (non-breaking change which fixes an issue with code or algorithm)
New feature (non-breaking change which adds functionality to code)
Breaking change (fix or feature that would cause existing functionality to change)
Config and build (change in the configuration and build system, has no impact on code or features)
Dependencies (update dependencies and changes associated, has no impact on code or features)
Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

My code follows the code style of this project (only if there are changes in source code).
My changes require an update to the documentation (there are changes that require the docs website to be updated).
I have updated the documentation accordingly (the changes require an update on the docs in this repo).
I have read the CONTRIBUTING document.
I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
I have added new tests to cover my changes.

changes: - throwing argument out of range exception when ssid is greater than 32 characters - throwing argument out of range exception when password is greater than 64 characters

coderabbitai · 2025-01-25T13:56:01Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

nanoFramework.System.Net/NetworkInformation/Wireless80211Configuration.cs is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

BoBoBaSs84 · 2025-01-25T14:00:27Z

@dotnet-policy-service agree

josesimoes

LGTM! Thank you for fixing it.

nfbot · 2025-01-27T10:57:00Z

@BoBoBaSs84 thank you again for your contribution! 🙏😄

.NET nanoFramework is all about community involvement, and no contribution is too small.
We would like to invite you to join the project's Contributors list.

Please edit it and add an entry with your GitHub username in the appropriate location (names are sorted alphabetically):

  <tr>
    <td><img src="https://github.com/BoBoBaSs84.png?size=50" height="50" width="50" ></td>
    <td><a href="https://github.com/BoBoBaSs84">Robert Peter Meyer</a></td>
  </tr>

(Feel free to adjust your name if it's not correct)

fix: using max values inclusive

21c1891

changes: - throwing argument out of range exception when ssid is greater than 32 characters - throwing argument out of range exception when password is greater than 64 characters

nfbot added the Type: bug Something isn't working label Jan 25, 2025

josesimoes approved these changes Jan 27, 2025

View reviewed changes

josesimoes changed the title ~~fix: using max values inclusive for ssid and password~~ Fix check for max values inclusive for ssid and password Jan 27, 2025

josesimoes enabled auto-merge (squash) January 27, 2025 10:56

josesimoes merged commit dbf6658 into nanoframework:main Jan 27, 2025
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix check for max values inclusive for ssid and password #337

Fix check for max values inclusive for ssid and password #337

Uh oh!

BoBoBaSs84 commented Jan 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 25, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

BoBoBaSs84 commented Jan 25, 2025

Uh oh!

josesimoes left a comment

Uh oh!

Uh oh!

nfbot commented Jan 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Fix check for max values inclusive for ssid and password #337

Fix check for max values inclusive for ssid and password #337

Uh oh!

Conversation

BoBoBaSs84 commented Jan 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

Checklist:

Uh oh!

coderabbitai bot commented Jan 25, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

BoBoBaSs84 commented Jan 25, 2025

Uh oh!

josesimoes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nfbot commented Jan 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BoBoBaSs84 commented Jan 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)