Adding several additional TryAdd methods #42

CoryCharlton · 2025-01-18T04:43:25Z

Description

Added several TryAdd methods
Brought code into line with .NET Core implementation

Motivation and Context

Exposes the same contracts as .NET Core which makes it easier to share code between projects

How Has This Been Tested?

Local
Unit tests

Screenshots

Types of changes

Improvement (non-breaking change that improves a feature, code or algorithm)
Bug fix (non-breaking change which fixes an issue with code or algorithm)
New feature (non-breaking change which adds functionality to code)
Breaking change (fix or feature that would cause existing functionality to change)
Config and build (change in the configuration and build system, has no impact on code or features)
Dependencies (update dependencies and changes associated, has no impact on code or features)
Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

My code follows the code style of this project (only if there are changes in source code).
My changes require an update to the documentation (there are changes that require the docs website to be updated).
I have updated the documentation accordingly (the changes require an update on the docs in this repo).
I have read the CONTRIBUTING document.
I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
I have added new tests to cover my changes.

Summary by CodeRabbit

Chores
- Updated Azure Pipelines configuration to modify the waitBeforeUpdate parameter logic for dependent updates.
- Adjusted the condition for when updates should wait based on the UPDATE_DEPENDENTS variable.

coderabbitai · 2025-01-18T04:43:34Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)

nanoFramework.DependencyInjection/nanoFramework.DependencyInjection.nfproj is excluded by none and included by none
tests/nanoFramework.DependencyInjection.UnitTests.nfproj is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request modifies the azure-pipelines.yml configuration file, specifically changing the logic for the waitBeforeUpdate parameter in the Update_Dependents job. The change reverses the condition for waiting before updating dependents, now waiting only when the UPDATE_DEPENDENTS variable is explicitly set to 'true'. This adjustment alters the control flow of the update process, potentially changing when and how dependent updates are triggered.

Changes

File	Change Summary
`azure-pipelines.yml`	Modified `waitBeforeUpdate` parameter logic in `Update_Dependents` job

Sequence Diagram

sequenceDiagram
    participant Pipeline
    participant Update_Dependents
    
    alt UPDATE_DEPENDENTS is 'true'
        Update_Dependents->>Pipeline: Wait before update
    else UPDATE_DEPENDENTS is not 'true'
        Update_Dependents->>Pipeline: Proceed without waiting
    end

The sequence diagram illustrates the new conditional logic for waiting before updating dependents, showing how the pipeline behavior changes based on the UPDATE_DEPENDENTS variable's value.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

CoryCharlton · 2025-01-30T22:46:01Z

@josesimoes I updated the mscorlib reference, removed the runtime reference, and replaced the ThrowHelper calls with ArgumentNullException this should be ready to merge.

josesimoes · 2025-01-31T12:09:30Z

@CoryCharlton seems that you've updated the refs in this PR which is conflicting with the ones from the automated updates. Can you please rebase this PR and fix the conflicts manually?

…Null`

- Rework AZDO yaml to include job to update dependents. ***NO_CI***

…Null`

- Delete file at project root. - Update path in AZDO yaml. ***NO_CI***

josesimoes · 2025-01-31T17:28:25Z

@CoryCharlton I believe I've got this right as it is. Problem seemed to be using merge instead of rebase and updating the refs here and also taking them from main... 🤪

josesimoes

LGTM! Thanks for this improvement.

sonarqubecloud · 2025-01-31T17:32:18Z

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

nfbot added Type: enhancement New feature or request Type: Unit Tests labels Jan 18, 2025

josesimoes force-pushed the main branch from a3e93b9 to db8dfce Compare January 31, 2025 00:38

CoryCharlton and others added 15 commits January 31, 2025 07:56

Adding several additional TryAdd methods

d42e928

Adding packages.lock.json

627e56d

Fixing missing dependency in nuspec

a71d4f8

Replace ThrowHelper.ThrowIfNull with `ArgumentNullException.ThrowIf…

7b02711

…Null`

Update nuspec

0218ca2

Work CI-CD

fd25e14

- Rework AZDO yaml to include job to update dependents. ***NO_CI***

Update test framework

d1bcacf

Adding several additional TryAdd methods

5a80a3e

Adding packages.lock.json

fcec76a

Fixing missing dependency in nuspec

3640588

Replace ThrowHelper.ThrowIfNull with `ArgumentNullException.ThrowIf…

30f8fe8

…Null`

Fix nfproj files

ed90015

Fix location of runsettings

f7d637e

- Delete file at project root. - Update path in AZDO yaml. ***NO_CI***

Update 2 NuGet dependencies

03dca65

Fix AZDO yaml

6c8298d

josesimoes approved these changes Jan 31, 2025

View reviewed changes

josesimoes merged commit 7375e3f into nanoframework:main Jan 31, 2025
7 checks passed

CoryCharlton deleted the extending_try_add branch January 31, 2025 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Adding several additional TryAdd methods #42

Adding several additional TryAdd methods #42

Uh oh!

CoryCharlton commented Jan 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 18, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

CoryCharlton commented Jan 30, 2025

Uh oh!

josesimoes commented Jan 31, 2025

Uh oh!

josesimoes commented Jan 31, 2025

Uh oh!

josesimoes left a comment

Uh oh!

sonarqubecloud bot commented Jan 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Adding several additional TryAdd methods #42

Adding several additional TryAdd methods #42

Uh oh!

Conversation

CoryCharlton commented Jan 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

Checklist:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

CoryCharlton commented Jan 30, 2025

Uh oh!

josesimoes commented Jan 31, 2025

Uh oh!

josesimoes commented Jan 31, 2025

Uh oh!

josesimoes left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 31, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CoryCharlton commented Jan 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)