-
-
Notifications
You must be signed in to change notification settings - Fork 186
Improve dev container comments for Azure RTOS (now ThreadX) #3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dev container comments for Azure RTOS (now ThreadX) #3147
Conversation
it is now Eclipse ThreadX
WalkthroughThe changes update documentation comments in two Dockerfiles and the README file to clarify repository naming. References to AzureRTOS have been revised to "Eclipse ThreadX (a.k.a. Azure RTOS)" for cloning repositories and for the description of available pre-built images. No functional changes or command modifications were introduced. Changes
Suggested labels
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.devcontainer/All/Dockerfile.All.SRC (1)
76-78: Updated Eclipse ThreadX Clone CommentThe updated comment for cloning Eclipse ThreadX repositories now clearly states “Eclipse ThreadX (a.k.a. Azure RTOS)”. Please verify that the branch versions (v6.4.0_rel for threadx and v6.3.0_rel for netxduo) are intentional and consistent with your release strategy.
.devcontainer/README.md (1)
16-18: Consistency and Minor Spelling ImprovementThe updates to the dev container selection options and Dockerfile references accurately reflect the new naming. However, the phrase “pre build container” appears in these sections; consider changing it to “pre-built container” for improved readability and to adhere to common spelling conventions.
Also applies to: 26-27
🧰 Tools
🪛 LanguageTool
[misspelling] ~16-~16: This expression is normally spelled as one or with a hyphen.
Context: ... are: *nanoFramework-Allto use the pre build container with all the elements to buil...(EN_COMPOUNDS_PRE_BUILD)
[misspelling] ~17-~17: This expression is normally spelled as one or with a hyphen.
Context: ... *nanoFramework-AzureRTOSto use the pre build container with all the elements to buil...(EN_COMPOUNDS_PRE_BUILD)
[misspelling] ~18-~18: This expression is normally spelled as one or with a hyphen.
Context: ...ts *nanoFramework-ChibiOSto use the pre build container with all the elements to buil...(EN_COMPOUNDS_PRE_BUILD)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.devcontainer/All/Dockerfile.All.SRC(1 hunks).devcontainer/AzureRTOS/Dockerfile.AzureRTOS.SRC(1 hunks).devcontainer/README.md(2 hunks)
🧰 Additional context used
🪛 LanguageTool
.devcontainer/README.md
[misspelling] ~16-~16: This expression is normally spelled as one or with a hyphen.
Context: ... are: * nanoFramework-All to use the pre build container with all the elements to buil...
(EN_COMPOUNDS_PRE_BUILD)
[misspelling] ~17-~17: This expression is normally spelled as one or with a hyphen.
Context: ... * nanoFramework-AzureRTOS to use the pre build container with all the elements to buil...
(EN_COMPOUNDS_PRE_BUILD)
⏰ Context from checks skipped due to timeout of 90000ms (17)
- GitHub Check: nf-interpreter (Nightly build) (Check_Build_Options)
- GitHub Check: nf-interpreter (Check_Build_Options)
- GitHub Check: build-target (TI_CC1352R1_LAUNCHXL, Debug, All, 915)
- GitHub Check: build-target (TI_CC1352R1_LAUNCHXL, Debug, TI, 915)
- GitHub Check: build-target (NXP_MIMXRT1060_EVK, Debug, All)
- GitHub Check: build-target (NXP_MIMXRT1060_EVK, Debug, FreeRTOS-NXP)
- GitHub Check: build-target (ESP32_H2_THREAD, Debug, ESP32)
- GitHub Check: build-target (ESP32_C6_THREAD, Debug, ESP32)
- GitHub Check: build-target (ESP32_C3, Debug, ESP32)
- GitHub Check: build-target (ESP32_S3, Debug, ESP32)
- GitHub Check: build-target (FEATHER_S2, Debug, ESP32)
- GitHub Check: build-target (ESP_WROVER_KIT, Debug, ESP32)
- GitHub Check: build-target (M5Core2, Debug, ESP32)
- GitHub Check: build-target (ST_STM32F769I_DISCOVERY, Debug, All)
- GitHub Check: build-target (ST_STM32F769I_DISCOVERY, Debug, ChibiOS)
- GitHub Check: build-target (SL_STK3701A, Debug, All)
- GitHub Check: build-target (SL_STK3701A, Debug, AzureRTOS)
🔇 Additional comments (3)
.devcontainer/AzureRTOS/Dockerfile.AzureRTOS.SRC (1)
65-67: Clear and Updated Repository Clone CommentThe comment now reads “Clone repos for Eclipse ThreadX (a.k.a. Azure RTOS)” which clearly reflects the new naming convention as intended by the PR. This update improves documentation without impacting functionality.
.devcontainer/All/Dockerfile.All.SRC (1)
69-69: Enhanced STM32 Repositories CommentThe revised comment now includes “Eclipse ThreadX (a.k.a. Azure RTOS)” for the STM32 support repositories, making it more transparent which repositories are being cloned.
.devcontainer/README.md (1)
11-11: Revised Pre-Built Image DescriptionThe entry for the Azure RTOS image now correctly identifies it as “Eclipse ThreadX (a.k.a. Azure RTOS) targets”. This clarification meets the PR objectives and improves overall documentation clarity.
Description
Updated the comments to refer to the fact that the name has changed.
Motivation and Context
It is now Eclipse ThreadX
How Has This Been Tested?
Screenshots
Types of changes
Checklist
Summary by CodeRabbit