[github-nfbot] Fix CI for dotnet build publishing #87
Conversation
The command changed with net7 Commented out unreachable code path.
WalkthroughThe pull request modifies the GitHub Actions workflow configuration for the NanoFramework GitHubBot. Specifically, the build step for an Azure Function has been updated, replacing the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (2).github/workflows/NanoFramework-GitHubBot.yml (2)Line range hint The PR description mentions changes required after transitioning from .NET 6 to .NET 7, but the workflow is configured to use .NET 8.0.x. Please clarify if this is intentional and if the build command changes are compatible with .NET 8. ✅ Verification successfulThe .NET 8 configuration is correct and intentional Based on the codebase analysis, the .NET 8 configuration in the workflow is correct and aligned with the project requirements. The main project
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for .NET version references in the repository
# Search for .NET version specifications
rg "DOTNET_VERSION.*[678]\.0"
# Search for documentation mentioning .NET versions
fd -e md -e txt | xargs rg -i "\.net.*(6|7|8)"
Length of output: 80 Script: #!/bin/bash
# Let's try a broader search for .NET version references and build configurations
# Search for any .NET version mentions in workflow files
rg -t yaml "dotnet" .github/workflows/
# Search for SDK or framework version references in project files
fd -e csproj | xargs rg "TargetFramework"
# Search for build or runtime configurations
rg -i "\.net" -g "*.{yml,yaml,csproj,props,targets}"
# Check PR description if available
gh pr view --json body
Length of output: 6099 🧰 Tools🪛 yamllint (1.35.1)[error] 34-34: trailing spaces (trailing-spaces)
The build command has been updated to use ✅ Verification successfulBuild command is correct for .NET 8 Azure Functions The build command using
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Search for similar Azure Function build commands in the repository
# to verify the correct usage of publish directory specification
# Search for other Azure Function build commands
rg -l "functions?" | xargs rg "dotnet build.*publish"
# Search for documentation files that might contain build instructions
fd -e md -e txt | xargs rg -i "azure.*(function|publish)"
Length of output: 434 Script: #!/bin/bash
# Let's check for any .NET 8 Azure Function examples or documentation in the repository
rg -i "net8.*function|function.*net8"
# Let's also check for any MSBuild property documentation or examples
rg -i "publishdir|publish.*directory" -A 2 -B 2
# Check for any build or publish related files
fd -e props -e targets | xargs cat
# Look for any Azure Function specific configuration
fd -g "*function*.json" -g "*host.json"
Length of output: 692 Script: #!/bin/bash
# Let's check the project file for publish configurations
cat "github-nfbot/GitHub-nfbot/GitHub-nfbot.csproj"
# Let's also check the workflow file itself for more context
cat ".github/workflows/NanoFramework-GitHubBot.yml"
# Check for any Azure Function specific configuration files
find . -name "host.json" -o -name "function.json" -type f | while read -r file; do
echo "=== $file ==="
cat "$file"
done
Length of output: 3081 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
networkfusion
changed the title
networkfusion
changed the title
Description
The command changed with net7 as per https://stackoverflow.com/questions/75548945/the-output-option-isnt-supported-when-building-a-solution
Commented out unreachable code path.
Related to the last run action:
Motivation and Context
Build publishing changed after .NET6
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Summary by CodeRabbit