Skip to content

MDC1 fix#208

Open
astrolamb wants to merge 5 commits intonanograv:masterfrom
astrolamb:mdc1_fix
Open

MDC1 fix#208
astrolamb wants to merge 5 commits intonanograv:masterfrom
astrolamb:mdc1_fix

Conversation

@astrolamb
Copy link
Copy Markdown
Contributor

@Hazboun6 @AaronDJohnson @stevertaylor
fixes model_general to use MDC1 - set flag mdc1=True

@astrolamb
Copy link
Copy Markdown
Contributor Author

@AaronDJohnson do you have a suggestion on how to fix these dependency errors?

@AaronDJohnson
Copy link
Copy Markdown
Collaborator

I'm not sure what is going on here. It looks like sksparse is failing to install, but nothing about it has changed since 2022.

@AaronDJohnson
Copy link
Copy Markdown
Collaborator

Okay. It's a problem with sksparse, but it's because Cython was updated yesterday. This needs to be fixed, but I may not have time to do it myself within the next week. A temporary fix could be to pin Cython to versions <3.0, but long term we don't want to do this.

@AaronDJohnson
Copy link
Copy Markdown
Collaborator

@astrolamb I've merged a temporary fix to scikit-sparse to constrain the Cython version to <3.0. I'll restart the tests in a couple of hours.

@astrolamb
Copy link
Copy Markdown
Contributor Author

Awesome, thanks @AaronDJohnson for finding this!

@AaronDJohnson
Copy link
Copy Markdown
Collaborator

Now the issue is with libstempo. Basically, the changes to Cython have broken most Cython packages. I've submitted a PR to libstempo to limit the Cython version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants