WIP: Alow model_singlepsr_noise to work with .tim TOA files that contain no pta/f flags#227
Draft
mattpitkin wants to merge 1 commit intonanograv:masterfrom
Draft
WIP: Alow model_singlepsr_noise to work with .tim TOA files that contain no pta/f flags#227mattpitkin wants to merge 1 commit intonanograv:masterfrom
mattpitkin wants to merge 1 commit intonanograv:masterfrom
Conversation
…at do not contain 'pta' or 'f' flags
Author
|
I've discovered that this breaks things due to the enterprise |
mattpitkin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if trying to use
model_singlepsr_noisewith aPulsarthat was created from a.timfile that contains noptaorfflag (e.g., something simulated by Tempo2) it will fail. This PR fixes this by using thegetdictionary method with a default empty string being returned.