Skip to content

Keep parameters as float128 values in tm_delay #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattpitkin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Keep parameters as float128 values in tm_delay #228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf4f80d
timing.py: keep parameters as float128 values in tm_delay
mattpitkin Mar 11, 2024
d4afb9d
timing.py: allow things to work on ARM64
mattpitkin Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions enterprise_extensions/timing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@
import numpy as np
from enterprise.signals import deterministic_signals, parameter, signal_base


try:
long_double_format = np.float128
except AttributeError:
# on ARM64 float128 is not available
long_double_format = np.double

# timing model delay


Expand All @@ -31,17 +38,19 @@ def tm_delay(residuals, t2pulsar, tmparams_orig, tmparams, which='all'):
orig_params = np.array([tmparams_orig[key] for key in keys])

# put varying parameters into dictionary
tmparams_rescaled = np.atleast_1d(np.double(orig_params[:, 0] +
tmparams * orig_params[:, 1]))
tmparams_rescaled = np.atleast_1d(
long_double_format(orig_params[:, 0] + tmparams * orig_params[:, 1])
)
tmparams_vary = OrderedDict(zip(keys, tmparams_rescaled))

# set to new values
t2pulsar.vals(tmparams_vary)
new_res = np.double(t2pulsar.residuals().copy())

# remember to set values back to originals
t2pulsar.vals(OrderedDict(zip(keys,
np.atleast_1d(np.double(orig_params[:, 0])))))
t2pulsar.vals(
OrderedDict(zip(keys, np.atleast_1d(long_double_format(orig_params[:, 0]))))
)

# Sort the residuals
isort = np.argsort(t2pulsar.toas(), kind='mergesort')
Expand Down