Bring dev branch into parity with "recent" commits to main#128
Merged
kayhangultekin merged 5 commits intodevfrom Nov 25, 2025
Merged
Bring dev branch into parity with "recent" commits to main#128kayhangultekin merged 5 commits intodevfrom
kayhangultekin merged 5 commits intodevfrom
Conversation
…urce strains in gravwaves._gws_harmonics_at_evo_fobs()
minor bugfix to add missing factor of 1/dlnf in definition of loud so…
Fixing errors in param_spaces_classic.py I believe the code in question was created to create a user-friendly way of reproducing the NANOGrav 15yr Astro Interpretation paper. It was not the code that we actually used for that analysis. This fix corrects a mistake introduced in an attempt to do "open science".
* Fixing errors in param_spaces_classic.py * Fix bug in sams/components.py --------- Co-authored-by: Shreyas Tiruvaskar <sti50@bohr.canterbury.ac.nz>
CayenneMatt
reviewed
Nov 21, 2025
Collaborator
CayenneMatt
left a comment
CayenneMatt
left a comment
There was a problem hiding this comment.
I agree that these changes should be added into dev.
kayhangultekin
commented
Nov 25, 2025
Collaborator
Author
kayhangultekin
left a comment
kayhangultekin
left a comment
There was a problem hiding this comment.
This looks good to me, and I got confirmation from @CayenneMatt. I am approving for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dev (main development branch) is behind main in a number of bug-fix commits. I think these are all straightforward non-breaking should-be-implemented bug fixes. Please review and give a thumbs-up if you agree.
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status