Closed
Conversation
…pointing this out.
* 'dev' of https://github.com/nanograv/holodeck: Warn users when there may be an inconsistent library parameter passed
Use compressed file to avoid 100MB github cap
Correcting the default for hard_gamma_outer in _PS_Astro_Strong: used to be 0.0 now it is +2.5
Added mamp_log10 as an attribute to MMBulge_Standard
The mbh_mass_func did not handle scatter appropriately and is now depricated. This function is replaced with mbh_mass_func_conv, which performs a convolution between the GSMF and MMBulge relation and is far more accurate. It still underestimates number density for the highest masses, but this is negligible for scatter_dex > 0.2
Added _zplaw as attribute to MMBulge_Standard (set to 0.0)
updated mbh_mass_func_conv to allow for evolving MMbulge
Fixed scatter implementation in mbh_mass_func_conv
Fixed missing import for stnorm
* Fixing errors in param_spaces_classic.py * minor bugfix to add missing factor of 1/dlnf in definition of loud source strains in gravwaves._gws_harmonics_at_evo_fobs() * Fix error in sams/components (#117) * Fixing errors in param_spaces_classic.py * Fix bug in sams/components.py --------- Co-authored-by: Shreyas Tiruvaskar <sti50@bohr.canterbury.ac.nz> --------- Co-authored-by: Shreyas Tiruvaskar <sti50@bohr.canterbury.ac.nz> Co-authored-by: Laura Blecha <lblecha@physicsplblecha.local> Co-authored-by: Luke Zoltan Kelley <lzkelley@gmail.com> Co-authored-by: Shreyas Tiruvaskar <153574373+shreyas-tiruvaskar@users.noreply.github.com>
…hange of gamma_outer from 0.0 to +2.5 in the last PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correcting a typo in the error for gsmf_alpha_two parameter prior. Used to be 0.15, now it is 0.015.
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status