Conversation
This was referenced Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From our discussions, this PR is intended to revamp the par checker into a more general data checker. This is being worked on in conjunction with the summary PDF rework (#145) with some items from the old PDF moving here. The main part of this code is heavily based on David Kaplan's ngchecker implementation for this purpose.
This code contains an abstract
DataCheckerclass and multiple sub-classes that inherit from this one:ParChecker: checks the required spin/astrometric parameters internally, and then calls the following two classes:NameChecker: checks the pulsar nameBinaryChecker: checks the binary parametersEpochChecker: checks the epoch centeringTOAChecker: checks the TOA versioning, allows for bad ranges to be defined here as well.Includes
data_checker.py,test_data_checker.py, and another 12.5-year data set tim file for unit testing. This also removespar_checker.pyandtest_par_checker.pyas obsolete.To-dos:
TOAChecker.