Skip to content

WIP: Data checker rework#147

Draft
mtlam wants to merge 3 commits intomainfrom
feature/par_checker_rework
Draft

WIP: Data checker rework#147
mtlam wants to merge 3 commits intomainfrom
feature/par_checker_rework

Conversation

@mtlam
Copy link
Copy Markdown
Member

@mtlam mtlam commented Feb 7, 2026

From our discussions, this PR is intended to revamp the par checker into a more general data checker. This is being worked on in conjunction with the summary PDF rework (#145) with some items from the old PDF moving here. The main part of this code is heavily based on David Kaplan's ngchecker implementation for this purpose.

This code contains an abstract DataChecker class and multiple sub-classes that inherit from this one:

  • ParChecker: checks the required spin/astrometric parameters internally, and then calls the following two classes:
    • NameChecker: checks the pulsar name
    • BinaryChecker: checks the binary parameters
  • EpochChecker: checks the epoch centering
  • TOAChecker: checks the TOA versioning, allows for bad ranges to be defined here as well.

Includes data_checker.py, test_data_checker.py, and another 12.5-year data set tim file for unit testing. This also removes par_checker.py and test_par_checker.py as obsolete.

To-dos:

  • Unit tests for TOAChecker.
  • Verify desired behavior on several of the other checkers.
  • Verify use of full tim files, or strip them down to a smaller size for unit tests.

@mtlam mtlam added this to the NG20 v2.0 requirements milestone Feb 7, 2026
@mtlam mtlam self-assigned this Feb 7, 2026
@mtlam mtlam added enhancement New feature or request discussed Discussed during a NANOGrav GitFlowers Meeting. labels Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussed Discussed during a NANOGrav GitFlowers Meeting. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant