Skip to content

(Not Checked) IPTA Unit Tests#70

Open
JamisonTalley wants to merge 11 commits intonanograv:mainfrom
JamisonTalley:IPTA_unit_tests
Open

(Not Checked) IPTA Unit Tests#70
JamisonTalley wants to merge 11 commits intonanograv:mainfrom
JamisonTalley:IPTA_unit_tests

Conversation

@JamisonTalley
Copy link
Copy Markdown
Collaborator

@JamisonTalley JamisonTalley commented Aug 2, 2024

This is an update to the tests directory in pint_pal that performs unit tests on most of the common methods used in the IPTA notebooks. These tests all pass on my versions of PINT and Pint Pal, but that is only one environment on one machine, so they probably need to be checked on the system that will actually be running the tests. Something to note is that there are scripts in the tests directory that have yet to be updated, and are likely incompatible with the current version of the software. There are more tests that may be helpful (see the commented out tests in test_lite_utils.py, for example), but I have yet to complete them.

This PR is prefaced as a Not Checked because it has not been cross-checked on a different system, but if these changes work on the testing system, they should be ready to merge. There was some discussion as to which branch the tests should be merged into, so this PR can be tweaked or recreated to fit whatever decision is made.

@JPGlaser
Copy link
Copy Markdown
Collaborator

JPGlaser commented Nov 1, 2024

@rossjjennings and @JamisonTalley , we need to include these tests into the GitHub Actions. Once its done and they successfully are tested by pytest, we can do a merge.

~ Joe G.

@rossjjennings
Copy link
Copy Markdown
Member

I experimented with checking out this branch and running the new tests it adds, and unfortunately a lot of them are failing for me.

@JamisonTalley
Copy link
Copy Markdown
Collaborator Author

That doesn't surprise me. These unit tests were written quite a while ago (before the NG20 merge), and because that merge was the primary target for these tests, it's possible that this PR is obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants