Open
Conversation
Collaborator
|
@rossjjennings and @JamisonTalley , we need to include these tests into the GitHub Actions. Once its done and they successfully are tested by pytest, we can do a merge. ~ Joe G. |
Member
|
I experimented with checking out this branch and running the new tests it adds, and unfortunately a lot of them are failing for me. |
Collaborator
Author
|
That doesn't surprise me. These unit tests were written quite a while ago (before the NG20 merge), and because that merge was the primary target for these tests, it's possible that this PR is obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update to the tests directory in pint_pal that performs unit tests on most of the common methods used in the IPTA notebooks. These tests all pass on my versions of PINT and Pint Pal, but that is only one environment on one machine, so they probably need to be checked on the system that will actually be running the tests. Something to note is that there are scripts in the tests directory that have yet to be updated, and are likely incompatible with the current version of the software. There are more tests that may be helpful (see the commented out tests in test_lite_utils.py, for example), but I have yet to complete them.
This PR is prefaced as a Not Checked because it has not been cross-checked on a different system, but if these changes work on the testing system, they should be ready to merge. There was some discussion as to which branch the tests should be merged into, so this PR can be tweaked or recreated to fit whatever decision is made.