Skip to content

nng: drop obsolete clippy::empty_enum allow#43

Open
flxo wants to merge 1 commit intonanomsg:mainfrom
flxo:nng/clippy
Open

nng: drop obsolete clippy::empty_enum allow#43
flxo wants to merge 1 commit intonanomsg:mainfrom
flxo:nng/clippy

Conversation

@flxo
Copy link
Collaborator

@flxo flxo commented Feb 20, 2026

Remove the #![allow(clippy::empty_enum)] suppression from nng/src/lib.rs.

The comment referenced RFC 1861 (extern types) and RFC 1216 (C-compatible enums), both of which have long since been resolved. The lint no longer fires on this codebase, making the allow unnecessary and event produces a clippy warning.

Summary by CodeRabbit

  • Chores
    • Updated internal code quality configurations.

Note: This release contains no user-facing changes or new features.

@coderabbitai
Copy link

coderabbitai bot commented Feb 20, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

A crate-level Clippy lint attribute permitting the empty_enum lint was removed from the library's root file. No functional or API changes were introduced.

Changes

Cohort / File(s) Summary
Lint Configuration
nng/src/lib.rs
Removed crate-level #![allow(clippy::empty_enum)] attribute.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A tiny lint flew away with the breeze,
One line removed with such ease,
The code hops along, clean and bright,
Configuration's just right! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing an obsolete Clippy allow attribute for empty_enum from the nng crate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@flxo flxo requested review from neachdainn February 20, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant