Conversation
Bump the nng crate from 1.0.1 to 2.0.0-v2pre.1 to fix cargo-semver-checks failures in CI. The crate has accumulated breaking API changes since the published 1.0.1 release, and a major version bump is the correct way to signal this under semver. The pre-release tag "v2pre" indicates that the crate is expected to undergo further breaking changes as it migrates to the NNG v2 API in the future.
📝 WalkthroughWalkthroughVersion bump in the nng crate from 1.0.1 to 2.0.0-v2pre.1, marking a pre-release of the next major version. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
nng/Cargo.toml (1)
7-7:⚠️ Potential issue | 🟡 MinorStale
repositoryURL points to the old GitLab location.The
repositoryfield still referenceshttps://gitlab.com/neachdainn/nng-rs, but the project now lives athttps://github.com/nanomsg/nng-rs. The description is a short blurb about the package; crates.io will display this with your package. Similarly, crates.io surfaces therepositoryfield prominently — publishing with the stale URL will direct users to the wrong location.Consider updating before publishing:
📝 Proposed fix
-repository = "https://gitlab.com/neachdainn/nng-rs" +repository = "https://github.com/nanomsg/nng-rs"And similarly for
[badges]:[badges] -gitlab = { repository = "neachdainn/nng-rs", branch = "master" } +# Badges section removed or updated; crates.io no longer renders badge metadata🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@nng/Cargo.toml` at line 7, The Cargo.toml contains a stale repository entry; update the repository = "https://gitlab.com/neachdainn/nng-rs" line to the new upstream URL repository = "https://github.com/nanomsg/nng-rs" and similarly update any entries under the [badges] section that point to the old GitLab location (and adjust the package description if it references the old location); modify the repository field and badge URL strings in Cargo.toml so they point to the new GitHub repo (look for the repository key and any badge URLs).
🧹 Nitpick comments (1)
nng/Cargo.toml (1)
14-14: Consider upgrading toedition = "2021"(or"2024").
edition = "2018"is pre-existing and unrelated to this PR, but since a major pre-release bump is being prepared, it's a good time to migrate. Rust 2021 offers improvements like disjoint closure captures andIntoIteratorfor arrays.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@nng/Cargo.toml` at line 14, The Cargo.toml currently sets edition = "2018"; update it to a modern Rust edition (e.g., change the edition key to "2021" or "2024") by editing the edition line in Cargo.toml, then run cargo build/cargo check and the test suite to catch any required code adjustments (closure captures, IntoIterator array changes, or lints) and update the CI/toolchain Rust version if needed to match the selected edition.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@nng/Cargo.toml`:
- Line 7: The Cargo.toml contains a stale repository entry; update the
repository = "https://gitlab.com/neachdainn/nng-rs" line to the new upstream URL
repository = "https://github.com/nanomsg/nng-rs" and similarly update any
entries under the [badges] section that point to the old GitLab location (and
adjust the package description if it references the old location); modify the
repository field and badge URL strings in Cargo.toml so they point to the new
GitHub repo (look for the repository key and any badge URLs).
---
Nitpick comments:
In `@nng/Cargo.toml`:
- Line 14: The Cargo.toml currently sets edition = "2018"; update it to a modern
Rust edition (e.g., change the edition key to "2021" or "2024") by editing the
edition line in Cargo.toml, then run cargo build/cargo check and the test suite
to catch any required code adjustments (closure captures, IntoIterator array
changes, or lints) and update the CI/toolchain Rust version if needed to match
the selected edition.
Bump the nng crate from
1.0.1to2.0.0-v2pre.1to fixcargo-semver-checksfailures in CI.The crate has accumulated breaking API changes since the published
1.0.1release, and a major version bump is the only way to signal this undersemver.The pre-release tag
v2preindicates that the crate is expected to undergo further breaking changes as it migrates to the NNG v2 API in the future.Summary by CodeRabbit