Conversation
|
Hey I wanted to ask if there is an effort to merge this merge request or are there any concerns. I would be very happy about the feature when it comes back:D |
Unfortunately, I don’t have a good project at hand to test it. @janhendry, can I ask you help me with testing this implementation? 😅 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for an actions API to the Nano Stores logger and related modules. Key changes include updates to the creation and logging of actions, adjustments in tests to verify action behaviors, and corresponding documentation updates.
Reviewed Changes
Copilot reviewed 18 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/index.ts | Adds the 'action' type to the badge regex for consistent action support. |
| printer/index.js | Introduces a new badge style for actions. |
| logger/types.ts | Updates the import path for the logger module. |
| logger/index.test.ts | Uncomments and activates action functions in tests. |
| logger/index.js | Integrates action logging into the logger with start, error, and end hooks. |
| logger/errors.ts | Demonstrates type failures for incorrect configuration of ignoreActions and mount options. |
| index.js | Exports the actions API. |
| demo/index.ts | Revises demo code to leverage the new actions API. |
| creator-logger/* | Incorporates actions into creator logger configuration and tests. |
| build-logger/index.js | Refactors logger builder to handle actions and ignore specific actions. |
| action/index.js | Introduces the actions API implementation. |
| README.md | Updates documentation to reflect the new action logging features. |
| .github/workflows/test.yml | Updates workflow permissions. |
Files not reviewed (4)
- creator-logger/snapshots/index.test.ts.snap: Language not supported
- logger/snapshots/index.test.ts.snap: Language not supported
- package.json: Language not supported
- pnpm-lock.yaml: Language not supported
0e68084 to
b709bde
Compare
No description provided.