Conversation
This reverts commit 151455e.
feat: actions api
There was a problem hiding this comment.
Pull Request Overview
This PR introduces updated action logging and error handling features while enhancing test coverage and documentation.
- Introduces a new "action" badge type in the logger and printer modules.
- Updates import paths and corrects type issues in logger/errors.ts.
- Improves demo and creator logger tests to use the new action APIs.
Reviewed Changes
Copilot reviewed 19 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/index.ts | Adds "action" as a valid tag type and simplifies mapping function. |
| printer/index.js | Adds a new badge style for "action" logging. |
| logger/types.ts | Updates the logger import path for improved module isolation. |
| logger/index.test.ts | Replaces direct store mutations with action calls in tests. |
| logger/index.js | Enhances action logging with a queue mechanism and clearer grouping. |
| logger/errors.ts | Adjusts type annotations to resolve TS errors related to options. |
| index.js | Exports the action API from the updated action module. |
| demo/index.ts | Updates demo code to leverage the new action patterns. |
| creator-logger/types.ts | Introduces ignoreActions option to the creator logger config. |
| creator-logger/index.test.ts | Integrates action-based logging tests for the creator logger. |
| build-logger/index.js | Refactors log handling by adding helper functions and better type checks. |
| action/index.js | Implements action tracking hooks and unified action workflows. |
| README.md | Updates documentation to reflect support for action log messages. |
| .github/workflows/test.yml | Updates Node.js and pnpm version configurations for CI. |
Files not reviewed (3)
- creator-logger/snapshots/index.test.ts.snap: Language not supported
- logger/snapshots/index.test.ts.snap: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
logger/errors.ts:20
- The mount message option should be a boolean value rather than a string; use true or false as appropriate.
mount: ''
| { atomStore }, | ||
| { | ||
| // THROWS Type 'string' is not assignable to type 'string[]' | ||
| ignoreActions: 'set', |
There was a problem hiding this comment.
The ignoreActions option should be provided as an array of strings (e.g. ['set']) instead of a single string.
Suggested change
| ignoreActions: 'set', | |
| ignoreActions: ['set'], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.