-
Notifications
You must be signed in to change notification settings - Fork 14
chore(ci): limit container job to master branch pushes #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe workflow configuration for building and pushing Docker images was updated to restrict execution to push events on the master branch, clarify step naming, specify build platform, adjust Docker build cache settings, and modify image tagging. Changes
Possibly related PRs
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/dotnet.yml (1)
137-140: Optimize build parameters and caching
Specifyingplatforms, disabling provenance, and enabling GitHub Actions cache (cache-from/cache-to) will speed up your Docker builds and reduce bandwidth.Optional enhancement: support multi-architecture builds by adding ARM64 alongside AMD64:
- platforms: linux/amd64 + platforms: linux/amd64,linux/arm64
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/dotnet.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (2)
.github/workflows/dotnet.yml (2)
112-112: Restrict container job to master branch pushes
The addedifconditional ensures thecontainerjob only runs on direct pushes to themasterbranch, preventing unnecessary Docker builds during pull requests. This matches the PR goal.
132-132: Clarify Docker step naming
Renaming the step to “Build and push Docker image to GitHub Container Registry” improves clarity by explicitly naming the target registry.



Summary by CodeRabbit